Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove anomaly and climatology #416

Merged
merged 3 commits into from
Jun 5, 2023
Merged

Conversation

anissa111
Copy link
Member

@anissa111 anissa111 commented Jun 5, 2023

PR Summary

Closes #356

  • Removes anomaly and climatology, which have had deprecation warnings since v2023.02.0
  • Also removes _find_time_invariant_vars and _setup_clim_anom_input from internal API, which were exclusively used in anomaly and climatology

PR Checklist

General

  • Link the issue this PR resolves by adding closes #XXX to the PR description where XXX is the number of the issue.
  • Add a brief summary of changes to docs/release-notes.rst
  • Add appropriate labels to this PR
  • Make your changes in a forked repository rather than directly in this repo
  • Open this PR as a draft if it is not ready for review
  • Convert this PR from a draft to a full PR before requesting reviewers
  • Passes precommit. To set up on your local, run pre-commit install from the top level of the repository. To manually run pre-commits, use pre-commit run --all-files and re-add any changed files before committing again and pushing.

@anissa111 anissa111 added the deprecation A feature is being deprecated or removed label Jun 5, 2023
@anissa111 anissa111 marked this pull request as ready for review June 5, 2023 19:21
@anissa111 anissa111 requested review from jukent and kafitzgerald June 5, 2023 19:21
@anissa111 anissa111 merged commit 72455e7 into NCAR:main Jun 5, 2023
@anissa111 anissa111 deleted the 356deprecate branch June 5, 2023 20:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
deprecation A feature is being deprecated or removed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove deprecated functions anomaly and climatology by v2023.05.0
3 participants